[FFmpeg-devel] [PATCH] Do not assume long is same width as x86 register in swscale.

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Mar 17, 2009 at 12:30:29PM +0000, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Tue, Mar 17, 2009 at 11:57:19AM +0000, M?ns Rullg?rd wrote:
>> >> Diego Biurrun <diego at biurrun.de> writes:
>> >> 
>> >> > On Mon, Mar 16, 2009 at 08:51:49PM -0300, Ramiro Polla wrote:
>> >> >> 
>> >> >> Now I have a question (Mans, Diego):
>> >> >> Since the code is in an external repo (swscale), should FFmpeg's
>> >> >> configure check for Virtual{Alloc,Free} and use it under that ifdef?
>> >> >> Or is ifdefing _WIN32 ok?
>> >> >
>> >> > I have no idea what you are referring to.  Maybe I will understand if you
>> >> > send a patch..
>> >> 
>> >> Follow the link above.  A patch awaits at the other end.
>> >
>> > I don't like it, there should be a feature check in configure.
>> 
>> Check for what?  Those function names are generic enough that they
>> could conceivably exist somewhere else, doing something else.  OTOH,
>> they are guaranteed to be available on win32.
>
> I don't see how a configure check should be unable to account for this.

My point exactly.

-- 
M?ns Rullg?rd
mans at mansr.com