[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Michael Niedermayer]

On Wed, Mar 18, 2009 at 04:22:18PM +0100, Olivier Guilyardi wrote:
> Michael Niedermayer wrote:
> > On Fri, Mar 13, 2009 at 09:05:38PM +0100, Olivier Guilyardi wrote:
[...]
> > [...]
> >> +        if (av_new_packet(&pkt, pkt_size) < 0) {
> >> +            av_log(context, AV_LOG_ERROR, "Could not create packet of size %d\n", pkt_size);
> >> +            return AVERROR(EIO);
> >> +        }
> >> +        av_fifo_generic_write(self->new_pkt_fifo, &pkt, sizeof(pkt), NULL);
> > 
> > it should be possible to use the function ptr argument of
> > av_fifo_generic_write to avoid the copy
> 
> Is saving the copy of 60 bytes worth the cost of:
> - extra function calls (that involves stack manipulation and others)
> - additional function and source lines

hmm, well then leave that part

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090318/7935c551/attachment.pgp>