[FFmpeg-devel] MXF D10 regression tests

[Michael Niedermayer]

On Thu, Mar 19, 2009 at 08:59:25AM +0100, Reimar D?ffinger wrote:
> On Thu, Mar 19, 2009 at 12:48:49AM +0100, Michael Niedermayer wrote:
> > On Thu, Mar 19, 2009 at 12:20:51AM +0100, Reimar D?ffinger wrote:
> > > On Wed, Mar 18, 2009 at 11:35:26PM +0100, Michael Niedermayer wrote:
> > > > > +        ff_fill_linesize(&picture, s->pix_fmt, w, stride_align);
> > > > > +
> > > > 
> > > > does something like:
> > > > retry:
> > > >     ff_fill_linesize(&picture, s->pix_fmt, w);
> > > >     if(any linesize % stride_align){
> > > >         w+= w&~(w-1);
> > > >         goto retry;
> > > >     }
> > > > 
> > > > work?
> > > 
> > > I can say for sure it would be a bit more ugly, like this it would be an
> > > endless loop for the paletted etc. formats (though if it makes sense too
> > > set a linesize for the palette is a different question).
> > 
> > ?
> > pal with linesize=0 would have if(0%16) and that should not loop endlessly
> > am i missing something?
> 
> Your missing that PAL8 currently has linesize[1] = 4

so change linesize to 0 or add a check for PAL8

its neither me who broke the regressions nor me who submitted the patch
(in case you try to implicate that i should be fixing this)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

GMX, the mailprovider that uses RBL lists to reject mails from your friends
running their own mailserver at home. The mailprovider that obscures the
origin of mails (mis)identified as viruses. The mailprovider that improves
security my disallowing more secure forms of authentication.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090319/1374a0b1/attachment.pgp>