[FFmpeg-devel] [PATCH] don't trust avi riff tag end

[Michael Niedermayer]

On Thu, Mar 19, 2009 at 11:32:32AM -0700, Baptiste Coudurier wrote:
> Hi,
> 
> On 3/18/2009 9:39 PM, Michael Niedermayer wrote:
> > On Wed, Mar 18, 2009 at 06:35:21PM -0700, Baptiste Coudurier wrote:
> >> Hi,
> >>
> >> $subject,
> >>
> >> This should fix demuxing avi generated through streaming and read
> >> through streaming.
> >>
> >> In the later case, RIFF tag end is 0, and when reading url_fsize will
> >> return 0.
> >>
> >> Like ffmpeg -i <file> -f avi - | ffmpeg -i -
> >>
> >> Any problem with this ?
> > 
> > fsize is used to detect damaged chunks, with INT64_MAX damaged chunks
> > are accepted and can lead to skiping of the whole file instead of searching
> > for the next valid chunk
> 
> I see, would it be ok to only set fsize to INT64_MAX when riff end tag
> is not set then ?

yes


> 
> Do you see any other alternative ?

some function to guess the max frame size
like width*height*X or audio_sample*channels or such

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090319/0559e29e/attachment.pgp>