[FFmpeg-devel] MXF D10 regression tests

[Michael Niedermayer]

On Thu, Mar 19, 2009 at 08:57:03PM +0100, Reimar D?ffinger wrote:
> On Thu, Mar 19, 2009 at 07:49:12PM +0100, Michael Niedermayer wrote:
> > On Thu, Mar 19, 2009 at 06:55:53PM +0100, Reimar D?ffinger wrote:
> > > On Thu, Mar 19, 2009 at 03:09:13PM +0100, Michael Niedermayer wrote:
> > > > On Thu, Mar 19, 2009 at 08:59:25AM +0100, Reimar D?ffinger wrote:
[...]
> > > > its neither me who broke the regressions
> > > 
> > > Since it just uncovered an existing bug there is not really anyone else
> > > to blame either though.
> > 
> > well last time i uncovered a unrelated bug (in the timestamping code, and
> > in gif and ...) i was flamed, now someone else uncovers one and again i
> > am the one pointed at
> 
> Well, blame is the thing you put where ever it is most convenient. ;-)

too true


> For the time stamp stuff I have to say for an outstander it often is not easy
> to say what is a bug or feature.
> Anyway let me say it like that: I do think that a maintainer always has
> a extra bit of responsibility for the correctness of "his" code.
> And I reserve for me the right to have human faults, in this case
> particularly not taking your time constraints into account after two
> rejected patches. Sorry if we end up a bit annoyed at each other
> occasionnally.

yes, indeed i agree, darn, you make it real hard for me to say anything
beyond agreeing


> 
> > > > nor me who submitted the patch
> > > 
> > > I protest the (hopefully not intended by you) implication that whoever
> > > tries to fix something suddenly becomes responsible for fixing it.
> > 
> > whoever wants something fixed or caused the bug, has to do the work.
> 
> I expect both apply to both of us in similar amounts :-)
> Anyway. have a look at attached patch. I tested it on x86 with modified
> STRIDE_ALIGN and it does fix the issue.
> Maybe I have taken "avoiding cosmetics" too far but that should be
> easily fixable. My dislike of goto shows a bit too compared to your
> original suggestion...

patch ok

PS: i considered to say "rejected" first as a joke ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090319/63e7e748/attachment.pgp>