[FFmpeg-devel] [PATCH][VAAPI][3/6] Add MPEG-2 bitstream decoding (take 5)

[Michael Niedermayer]

On Sun, Mar 22, 2009 at 10:30:37AM +0100, Gwenole Beauchesne wrote:
> Le 22 mars 09 ? 04:05, Michael Niedermayer a ?crit :
[...]
>>> +    switch (s->pict_type) {
>>> +    case FF_I_TYPE:
>>> +        break; // no prediction from other frames
>>> +    case FF_B_TYPE:
>>> +        pic_param->backward_reference_picture = 
>>> ff_vaapi_get_surface(&s->next_picture);
>>> +        // fall-through
>>> +    case FF_P_TYPE:
>>> +        pic_param->forward_reference_picture = 
>>> ff_vaapi_get_surface(&s->last_picture);
>>> +        break;
>>
>>> +    default:
>>> +        assert(0);
>>> +        return -1;
>>
>> this is ugly and wrong
>> pict_type can at least be that dc only mpeg1 thing too IIRC
>
> I am sorry but I don't understand what you wrote. Could you please 
> elaborate? Do you mean keep only P and B types and nuke I and default cases 
> away?

that would be an option 
[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090323/5a35fb5c/attachment.pgp>