[FFmpeg-devel] [PATCH] add _XOPEN_SOURCE definition to tools/trasher.c

[Diego Biurrun]

On Tue, Mar 24, 2009 at 01:29:32AM +0100, Michael Niedermayer wrote:
> On Tue, Mar 24, 2009 at 12:01:04AM +0100, Diego Biurrun wrote:
> > On Mon, Mar 23, 2009 at 10:32:16PM +0000, M?ns Rullg?rd wrote:
> > > Diego Biurrun <diego at biurrun.de> writes:
> > > 
> > > > When compiling tools/trasher.c the following warnings appear:
> > > >
> > > > tools/trasher.c: In function 'main':
> > > > tools/trasher.c:44: warning: implicit declaration of function 'srandom'
> > > > tools/trasher.c:51: warning: implicit declaration of function 'random'
> > > >
> > > > According to
> > > >
> > > > http://www.opengroup.org/onlinepubs/009695399/functions/srandom.html
> > > >
> > > > (s)random is an XSI extension, so adding
> > > >
> > > > #define _XOPEN_SOURCE 600
> > > >
> > > > to the file seems to be the correct solution.
> > > 
> > > You attached an empty file.  I don't think I've seen that before.  And
> > > in the same breath as commenting on somebody else's lack of patch too...
> > 
> > Clearly, I was destined to come up with clever new ways to botch patch
> > attachment.  Just forgetting it for the 999th time would not give
> > anybody comic relief...
> 
> you could post the patch and attach the reply next time

:)

> about the patch, why not use lfg lcg or any other generate we have?

It would considerably bloat the size of the program.  I think the idea
is for those tiny tools to be standalone.  random() seems to be good
enough for this use case.

Diego