[FFmpeg-devel] [PATCH][VAAPI][4/6] Add MPEG-4 / H.263 bitstream decoding (take 6)

[Michael Niedermayer]

On Thu, Mar 26, 2009 at 11:44:50PM +0100, Gwenole Beauchesne wrote:
> Le 26 mars 09 ? 22:36, Michael Niedermayer a ?crit :
>
>> On Thu, Mar 26, 2009 at 07:32:30PM +0100, Gwenole Beauchesne wrote:
>>> Le 26 mars 09 ? 19:17, Michael Niedermayer a ?crit :
>>>
>>>> [...]
>>>>> +/** Reconstruct bitstream num_gobs_in_vop */
>>>>> +static inline int mpeg4_get_num_gobs_in_vop(MpegEncContext *s)
>>>>> +{
>>>>> +    static const uint16_t num_gobs_in_vop_table[8] =
>>>>> +        { 0, 6, 9, 18, 18, 18, 0, 0 };
>>>>> +    return num_gobs_in_vop_table[mpeg4_get_source_format(s)];
>>>>> +}
>>>>
>>>> please remove these functions
>>>
>>> Then please approve
>>> <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-March/066392.html>
>>> ;-)
>>> I don't see how I can do otherwise.
>>
>> i cant approve it because it contains the same unacceptable 1 line 
>> functions
>
> Why? And, what do you suggest then?

just write func1() instead of

func2(){
    func1();
}

func2();

why? because the code is totally unreadable as is

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090327/362841e2/attachment.pgp>