[FFmpeg-devel] [PATCH] FLAC parser

Michael Niedermayer michaelni
Sat Mar 28 19:00:21 CET 2009


On Fri, Mar 27, 2009 at 01:05:47AM -0400, Justin Ruggles wrote:
> Hi,
> 
> I finally got a working FLAC parser without resorting to buffering
> max_frame_size bytes like the FLAC decoder does.  It requires a slight
> change to ff_combine_frame() since the header can be up to 16 bytes long
> and ff_combine_frame() currently only supports up to 8 bytes of overread
> data (FF_INPUT_BUFFER_PADDING_SIZE).
> 
> This works with all samples I've tested, but it would be great to have
> more tested as well.  There are quite a few corner cases, and while I've
> tried to think of everything I can, I might have missed something.

If i understand this correctly,
this is a probabilistic parser, that is it will fail once in 4tb of
random data at least, but due to the max crc stuff sooner.
and as data is not random it could fail more frequently

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090328/4b8a5a1d/attachment.pgp>



More information about the ffmpeg-devel mailing list