[FFmpeg-devel] [PATCH] Indeo5 decoder

[Diego Biurrun]

On Mon, Mar 30, 2009 at 12:35:37PM +0200, Maxim wrote:
> Diego Biurrun schrieb:
> > On Mon, Mar 30, 2009 at 01:51:10AM +0200, Maxim wrote:
> >   
> > [...]
> 
> > Capitalize and add period.
> >
> > What sort of macroblock?  This is not very descriptive..
> 
> Hmm, there are three different macroblock sizes: 16x16, 8x8 and 4x4.
> Otherwise the term "macroblock" has the same meaning as by the MPEG...
> No idea how to make it more descriptive...

Indeo macroblocks?

"This structure describes foo" is redundant and just "foo" should be
enough.

> >> +int  ff_ivi_create_huff_from_desc (const IVIHuffDesc *cb, VLC *pOut, int flag);
> >> +int  ff_ivi_dec_huff_desc         (GetBitContext *gb, IVIHuffDesc *desc);
> >> +int  ff_ivi_huff_desc_cmp         (const IVIHuffDesc *desc1, const IVIHuffDesc *desc2);
> >> +void ff_ivi_huff_desc_copy        (IVIHuffDesc *dst, const IVIHuffDesc *src);
> >> +int  ff_ivi_init_planes           (IVIPlaneDesc *planes, const IVIPicConfig *cfg);
> >> +void ff_ivi_free_buffers          (IVIPlaneDesc *planes);
> >> +int  ff_ivi_init_tiles            (IVIPlaneDesc *planes, const int tile_width, const int tile_height);
> >> +int  ff_ivi_dec_tile_data_size    (GetBitContext *gb);
> >> +void ff_ivi_inverse_slant_8x8     (int32_t *in, int16_t *out, uint32_t pitch);
> >> +void ff_ivi_inverse_slant_4x4     (int32_t *in, int16_t *out, uint32_t pitch);
> >> +void ff_ivi_dc_slant_2d           (int32_t *in, int16_t *out, uint32_t pitch, int blk_size);
> >> +int  ff_ivi_decode_blocks         (GetBitContext *gb, IVIBandDesc *band, IVITile *tile);
> >> +void ff_ivi_process_empty_tile    (IVIBandDesc *band, IVITile *tile, int32_t mv_scale);
> >> +void ff_ivi_output_plane          (IVIPlaneDesc *plane, uint8_t *dst, int dst_pitch);
> >>     
> >
> > This looks somewhat weird aligned, it is not necessarily a bad idea, but
> > uncommon.
> 
> leave unaligned?

Yes, I think so.

> >> --- libavcodec/indeo5data.h	(Revision 0)
> >> +++ libavcodec/indeo5data.h	(Revision 0)
> >> @@ -0,0 +1,211 @@
> >> +/**
> >> + *  standard picture dimensions
> >
> > That's little detail, standard for what?
> 
> These are actually standard picture sizes, i.e.  4CIF (640x480) or CIF
> (320x240).
> Would be the spelling "frequently used picture sizes" be better?//

No, it's probably OK as-is.

Diego