[FFmpeg-devel] [PATCH] Pass pointer of correct type for timestamp to ff_rm_parse_packet

[Eli Friedman]

On Mon, Mar 30, 2009 at 5:15 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Mon, Mar 30, 2009 at 5:07 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> Per subject. ?The actual bug is in the following code in rdt_parse_packet:
>> ? ? ? ?res = ff_rm_parse_packet (rdt->rmctx, &pb, st,
>> rdt->rmst[st->index], len, pkt,
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?&seq, &flags, timestamp);
>>
>> ff_rm_parse_packet takes a uint64_t* for the timestamp, but it was
>> getting passed a uint32_t*. ?The fix is spread over a few files
>> because the pointer in question gets passed through a few different
>> functions.
>
> Can't you just fix this one by a copy (uint64 x = y;, where y is a
> uint32, or the reverse) instead of changing all to be a uint64?

I can't figure out how the heck this code is supposed to work, so I
don't really want to mess with the logic... and truncating a timestamp
seems like a bad idea.

-Eli