[FFmpeg-devel] [Fwd: Summer of code small task patch]

Diego Biurrun diego
Tue Mar 31 10:11:40 CEST 2009


On Tue, Mar 31, 2009 at 08:52:30AM +0200, Dylan Yudaken wrote:
> 
> --- a/libavcodec/dct-test.c
> +++ b/libavcodec/dct-test.c

I dunno how you created this patch, but it seems you did not use
mechanical search and replace - bad idea, some typos crept in.

> --- a/libavcodec/dct-test.c
> +++ b/libavcodec/dct-test.c
> @@ -90,57 +90,57 @@ struct algo {
>  
>  #if HAVE_ALTIVEC
> -  {"altivecfdct",     0, fdct_altivec,       fdct, NO_PERM, FF_MM_ALTIVEC},
> +  {"altivecfdct",     0, fdct_altivec,       ff_ref_dct, NO_PERM, FF_MM_ALTIVEC},

typo

>  #if ARCH_ALPHA
> -  {"SIMPLE-ALPHA",    1, ff_simple_idct_axp,  idct, NO_PERM },
> +  {"SIMPLE-ALPHA",    1, ff_simple_idct_axp,  ref_idct, NO_PERM },

another typo

Diego

P.S.: Dylan, your patches have mime-type application/mbox, this is weird
and not helpful when trying to view patches inline.

P.P.S.: You can earn extra good karma if you improve your quoting habits
by leaving blank lines between your reply and the quoted text.



More information about the ffmpeg-devel mailing list