[FFmpeg-devel] [PATCH] Implement av_get_token()

[Michael Niedermayer]

On Fri, May 01, 2009 at 01:33:09PM +0200, Stefano Sabatini wrote:
> On date Thursday 2009-04-30 03:45:13 +0200, Michael Niedermayer encoded:
> > On Sat, Apr 25, 2009 at 01:21:49PM +0200, Stefano Sabatini wrote:
> [...]
> > > > add \ at the end escaing the traiing null
> > > > and unterminated '
> > > > and escaped leading and trailing whitespace
> > > 
> > > OK.
> > > 
> > > [..]
> > > > > +    /* strip trailing whitespaces */
> > > > > +    out--;
> > > > > +    while(--out >= ret && strspn(out, WHITESPACES))
> > > > > +        *out = 0;
> > > > 
> > > > this will remove escaped trailing whitespaces
> > > 
> > > Reimplemeneted as a finite state machine, as the previous apporach was
> > > resulting messy and unreadable.
> > 
> > i do not plan to approve this patch
> > i think work should continue based on the previous version
> > which was cleaner, simpler and smaller
> > it only had one trivial bug
> 
> The previous patch had more problems that it looked, especially for
> which regarded the terminating condition which I'm explicitely setting
> now (for this I'm using the is_end var).
> 
> Other than this, the attached patch is absolutely equivalent to the
> previous one in term of functionality (and now that I look at it I may
> agree it's nicer).

patch rejected, i will try to fix the previous version myself.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090501/7b4baae9/attachment.pgp>