[FFmpeg-devel] [PATCH] Remove unused code

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Fri, May 01, 2009 at 11:50:55PM +0200, Benjamin Larsson wrote:
>> Dead assignments found by CSA.
>> 
>> Index: libavcodec/ratecontrol.c
>> ===================================================================
>> --- libavcodec/ratecontrol.c	(revision 18726)
>> +++ libavcodec/ratecontrol.c	(working copy)
>> @@ -754,7 +754,6 @@
>>          rcc->mv_bits_sum[pict_type] += rce->mv_bits;
>>          rcc->frame_count[pict_type] ++;
>>  
>> -        bits= rce->i_tex_bits + rce->p_tex_bits;
>>          rate_factor= rcc->pass1_wanted_bits/rcc->pass1_rc_eq_output_sum * br_compensation;
>>  
>>          q= get_qscale(s, rce, rate_factor, picture_number);
>
> i think, i didnt apply this because this makes bits more correct even
> if unused.
> not a big issue though ...

If it is not used, how can you say anything about its correctness?

-- 
M?ns Rullg?rd
mans at mansr.com