[FFmpeg-devel] [PATCH] fix parsing of broken mp3 streams

[Zdenek Kabelac]

2009/5/2 Diego Biurrun <diego at biurrun.de>:
> On Sat, May 02, 2009 at 03:46:22AM +0200, Michael Niedermayer wrote:
>> On Sun, Apr 19, 2009 at 11:18:06PM +0200, Zdenek Kabelac wrote:
>> >
>> > --- libavcodec/mpegaudiodec.c ? ? ? (revision 18627)
>> > +++ libavcodec/mpegaudiodec.c ? ? ? (working copy)
>>
>> ok
>
> Kabi, could you suggest a good commit message?
>

- do not scan for mp3 header after the given buffer.
- return skipped bytes with consumed on successful decoding.

However as was said during this thread - it's not really clear to me
whether the decoder should really scan buffer for frame start - or
this should be left only to parser - and if the given buffer is not
mp3 it would be immediately rejected - without checking buffer for
potential frame.

So my patch currently fixes some core dumps for broken streams - but
it could be that some more advanced modification might be necessary
later.

Zdenek