[FFmpeg-devel] [RFC] Scalar color conversion utils (colorutils.[hc])?

[Diego Biurrun]

On Mon, May 04, 2009 at 01:08:33AM +0200, Stefano Sabatini wrote:
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ libavfilter-soc/ffmpeg/libavfilter/colorutils.c	2009-05-04 01:04:50.000000000 +0200
> @@ -0,0 +1,246 @@
> +
> +int main()

Once more with feeling:

  int main(void)

You cannot leave this out, it's not just consistency pedantry.

> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ libavfilter-soc/ffmpeg/libavfilter/colorutils.h	2009-05-04 01:06:34.000000000 +0200
> @@ -0,0 +1,41 @@
> +/*
> + * Stefano Sabatini 2009

What is this?

> +/**
> + * Parses the color string in color_string, and puts in rgba_color the
> + * RGBA component values of the corresponding color.

Your most common grammmar mistake.  In English it is

  put what where

not

  put where what

(like it probably is in Italian).

Diego