[FFmpeg-devel] [PATCH] 8088flex TMV demuxer and decoder

[Michael Niedermayer]

On Wed, May 06, 2009 at 03:28:30AM -0500, Daniel Verkamp wrote:
> On Fri, Apr 24, 2009 at 12:01 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > ss On Fri, Apr 24, 2009 at 05:48:02PM +0200, Reimar D?ffinger wrote:
> >> On Fri, Apr 24, 2009 at 09:59:05AM -0500, Daniel Verkamp wrote:
> >> > Hmm, I get the same "any seek resets to beginning" behavior with
> >> > ffplay and the nirvana.nuv file from samples.mphq (the nuv demuxer
> >> > seems to do what you're saying too, setting AVFMT_GENERIC_INDEX and
> >> > PKT_FLAG_KEY). ?Seeking in general in ffplay seems to work fine (at
> >> > least mpeg).
> >>
> >> I vaguely remember something. I think ffplay always tries to seek
> >> relative to the full duration,
> >
> > cursor keys shouldnt use the duration i think ...
> >
> >
> >> but gets the duration completely wrong.
> >
> > why dont you set the duration in the demuxer? (and or the bitrates of all
> > streams?)
> >
> 
> New demuxer patch attached, which now sets the bitrate for video
> stream, resulting in correct automatic calculation of duration based
> on file size.
> 
> Anything else needed for the demuxer?  CGA data and decoder are
> already OK'd by Michael earlier in this thread.
[...]
> +typedef struct TMVContext {
> +    unsigned audio_chunk_size;

> +    unsigned comp_method;

could be a local var, so could others

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090506/d520f040/attachment.pgp>