[FFmpeg-devel] [PATCH] 8088flex TMV demuxer and decoder

[Stefano Sabatini]

On date Wednesday 2009-05-06 09:43:35 -0500, Daniel Verkamp encoded:
> On Wed, May 6, 2009 at 7:34 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, May 06, 2009 at 03:28:30AM -0500, Daniel Verkamp wrote:
> [...]
> >>
> >> New demuxer patch attached, which now sets the bitrate for video
> >> stream, resulting in correct automatic calculation of duration based
> >> on file size.
> >>
> >> Anything else needed for the demuxer? ?CGA data and decoder are
> >> already OK'd by Michael earlier in this thread.
> > [...]
> >> +typedef struct TMVContext {
> >> + ? ?unsigned audio_chunk_size;
> >
> >> + ? ?unsigned comp_method;
> >
> > could be a local var, so could others
> >
> 
> audio_chunk_size is needed in read_packet(); all other context vars
> that can be local have now been made so.
> 
> Also added:
> - a check to avoid dividing by zero when audio chunk size is 0
> - video_chunk_size var to replace hardcoded 2000s everywhere
> 
> > [...]
> > --
> > Michael ? ? GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Thanks,
> -- Daniel Verkamp

> From 50f0094cdb346c444b77b2a4c96fce249d88226b Mon Sep 17 00:00:00 2001
> From: Daniel Verkamp <daniel at drv.nu>
> Date: Fri, 24 Apr 2009 10:00:25 -0500
> Subject: [PATCH 3/3] 8088flex TMV demuxer
> 
> ---
>  libavformat/Makefile     |    1 +
>  libavformat/allformats.c |    1 +
>  libavformat/tmv.c        |  156 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 158 insertions(+), 0 deletions(-)
>  create mode 100644 libavformat/tmv.c

Missing change to avcodec.h with the TMV codec id definition.

Also please provide a change to the list of supported file formats in
doc/general.texi.

Regards. 
-- 
FFmpeg = Foolish Fostering Miracolous Ponderous Epehemeral Governor