[FFmpeg-devel] [PATCH] Add DPX decoder

[Jimmy Christensen]

On 2009-05-06 18:54, Michael Niedermayer wrote:
> On Wed, May 06, 2009 at 05:04:50PM +0200, Jimmy Christensen wrote:
>> On 2009-05-06 14:27, Jimmy Christensen wrote:
>>> Hi,
>>>
>>> Added DPX decoder codec. Only support 10-bit and does no log to lin
>>> conversion, which means it only supports linear DPX files. Have tested
>>> with DPX files from various software and it seems to work ok with them.
>>>
>>> Based largely on the TGA decoder.
>>>
>>> Best Regards
>>> Jimmy Christensen
>>> Developer
>>> Ghost A/S
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at mplayerhq.hu
>>> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>>
>> Hi,
>>
>> Hopefully all formatting issues should be solved now.
>>
>> Didn't mean to take up all of everyone's time educating me :)
>>
>> Changed format to rgb24 instead of rgb32, since 10bit DPX files can never
>> have alpha channels. Ofcourse discarding 2 bit is unwanted, but is seems
>> that RGB48 is not well supported at the moment.
>
> this may very well be, but it still doesnt make rgb24 an acceptable choice
>

So what would you suggest? Change it to RGB48 and add support for RGB48 
in swScaler? The only output possible of RGB48 input is RGB48, which is 
only supported by the pnm encoder AFAIK.

This would make a dpx reader in ffmpeg a little useless. Then you would 
be better off using something like imagemagick/graphicsmagick instead of 
ffmpeg, since it's only image convertion.

Even the pnm decoder can't output anything else than pnm (since it's the 
only encoder supporting RGB48 output). Try with this sample :
http://samples.mplayerhq.hu/image-samples/lighthouse_rgb48.ppm

I would suggest keep it RGB24 currently, add RGB48 to the swscaler and 
change the DPX reader to RGB48 when swscaler can do RGB48.

Best Reards
Jimmy Christensen