[FFmpeg-devel] FFmpeg 0.5.1

[Diego Biurrun]

On Wed, May 06, 2009 at 03:41:26PM -0300, Ramiro Polla wrote:
> On Wed, May 6, 2009 at 2:32 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Wed, May 06, 2009 at 12:34:11PM -0300, Ramiro Polla wrote:
> >> On Wed, May 6, 2009 at 9:18 AM, Diego Biurrun <diego at biurrun.de> wrote:
> >> > Is there anything extremely important I missed for the 0.5 branch?
> >>
> >> Not extremely important, but I backported a couple of mingw32
> >> configure changes to help cross-compiling and bundling -dev packages.
> >
> > Next time wait for approval before committing to the 0.5 branch unless
> > you want to make me really angry.
> >
> > Just checked, you did not even merge things properly, but just committed
> 
> Hmm, I'm guessing patch && svn ci was the wrong approach,

Yes.

> and something along the lines of svn merge should be used?

Indeed.

> The proper procedure for backporting should be documented.

Subversion comes with excellent and extensive documentation.  Why did
you not peruse it?  Have you never worked with a branch before?  If no,
why did you just commit without double checking?  If yes, why did you
mess up?

Is your client version <1.5 or >1.5?

> > a diff and used a crap commit message to boot. ?No need to wait for next
> > time to make me angry, 100% success on your first try already.
> 
> I agree the commit message kind of sucks.

Then why did you use it?

> I suggest backporting commit
> messages should be consistent, documented, and something like:
> Backport r# from trunk:
> <original commit message>

Pointless redundant information.


I'm still waiting for you to remove the mess I never approved.

Diego