[FFmpeg-devel] [PATCH] Yet another stab at RGB48 support

[Kostya]

On Sat, May 09, 2009 at 07:31:20PM +0200, Diego Biurrun wrote:
> On Sat, May 09, 2009 at 02:28:18PM +0300, Kostya wrote:
> > $subj
> 
> Changelog update is missing.
> 
> $nits below
> 
[...]
reformatted, splitted some long lines.
Since this is diff against libswscale, no Changelog entry (but I
remember about it).
 
[...]
> > +SwsRGBFunc sws_hires_getRGBFunc(SwsContext *c)
> > +{
> > +    const enum PixelFormat srcFormat= c->srcFormat;
> > +    const enum PixelFormat dstFormat= c->dstFormat;
> > +    const int srcCbe= srcFormat==PIX_FMT_RGB48BE; /* components big-endian */
> > +    const int dstCbe= dstFormat==PIX_FMT_RGB48BE;
> > +    const int srcBpp= (fmt_depth(srcFormat) + 7) >> 3;
> > +    const int dstBpp= (fmt_depth(dstFormat) + 7) >> 3;
> > +    const int srcId= (fmt_depth(srcFormat) >> 2) - (srcBpp > 4); /* 1:0, 4:1, 8:2, 15:3, 16:4, 24:6, 32:8, 48:11 */
> > +    const int dstId= (fmt_depth(dstFormat) >> 2) - (dstBpp > 4);
> > +    SwsRGBFunc conv = NULL;
> 
> extra good karma for spaces around =, same below

Warum du fixiert da in alle FFmpeg nicht?

[...]
> 
> > --- hires.h	(revision 0)
> > +++ hires.h	(revision 0)
> > @@ -0,0 +1,33 @@
> > +
> > +#include <inttypes.h>
> 
> stdint.h should be enough.
> 
> > +#include "swscale.h"
> > +#include "swscale_internal.h"
> 
> Why do you need both?

For SwsFunc definition.
 
> > --- swscale_template.c	(revision 29274)
> > +++ swscale_template.c	(working copy)
> > @@ -2130,6 +2130,86 @@
> >  
> > +static inline void RENAME(rgb48beToUV)(uint8_t *dstU, uint8_t *dstV, uint8_t *src1, uint8_t *src2, int width)
> 
> long line, same below
> 
> Diego

Offtopic: will you be able to invite me to Germany on LinuxTag?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 48bpp.patch
Type: text/x-diff
Size: 28366 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090510/3fc04224/attachment.patch>