[FFmpeg-devel] [PATCH] Yet another stab at RGB48 support

[Kostya]

On Sun, May 10, 2009 at 03:43:52PM +0200, Diego Biurrun wrote:
> On Sun, May 10, 2009 at 03:21:23PM +0300, Kostya wrote:
> > On Sat, May 09, 2009 at 07:31:20PM +0200, Diego Biurrun wrote:
> > > On Sat, May 09, 2009 at 02:28:18PM +0300, Kostya wrote:
> > > > +SwsRGBFunc sws_hires_getRGBFunc(SwsContext *c)
> > > > +{
> > > > +    const enum PixelFormat srcFormat= c->srcFormat;
> > > > +    const enum PixelFormat dstFormat= c->dstFormat;
> > > > +    const int srcCbe= srcFormat==PIX_FMT_RGB48BE; /* components big-endian */
> > > > +    const int dstCbe= dstFormat==PIX_FMT_RGB48BE;
> > > > +    const int srcBpp= (fmt_depth(srcFormat) + 7) >> 3;
> > > > +    const int dstBpp= (fmt_depth(dstFormat) + 7) >> 3;
> > > > +    const int srcId= (fmt_depth(srcFormat) >> 2) - (srcBpp > 4); /* 1:0, 4:1, 8:2, 15:3, 16:4, 24:6, 32:8, 48:11 */
> > > > +    const int dstId= (fmt_depth(dstFormat) >> 2) - (dstBpp > 4);
> > > > +    SwsRGBFunc conv = NULL;
> > > 
> > > extra good karma for spaces around =, same below
> > 
> > Warum du fixiert da in alle FFmpeg nicht?
> 
> Es sind so viele :)
> Vielleicht irgendwann...

find . -name "*.[ch]" -exec egrep -H "[0-9a-z]= " {} \;
Oder irgendetwas.
 
> > Offtopic: will you be able to invite me to Germany on LinuxTag?
> 
> Ooooops, forgot about it, yes, I can do it..

thank you
 
> > +static int rgb48togray16_template(SwsContext *c, uint8_t *src[],
> > +                                  int srcStride[], int srcSliceY,
> > +                                  int srcSliceH, uint8_t *dst[],
> > +                                  int dstStride[], const int srcLE,
> > +                                  const int dstLE) {
> 
> one more K&R nit

fixed locally, will wait for technical review
 
> Diego