[FFmpeg-devel] [PATCH] Add DPX decoder rev-4

[Diego Biurrun]

On Mon, May 11, 2009 at 07:11:02AM +0200, Jimmy Christensen wrote:
> On 2009-05-08 16:10, Diego Biurrun wrote:
> >On Thu, May 07, 2009 at 10:02:08AM +0200, Jimmy Christensen wrote:
> >>On 2009-05-06 14:27, Jimmy Christensen wrote:
> >
> >Please trim your quotes.
> 
> Done and will do.

Thanks.

> >>--- libavcodec/dpx.c	(revision 0)
> >>+++ libavcodec/dpx.c	(revision 0)
> >>@@ -0,0 +1,166 @@
> >>+    const uint8_t *headerBuffer = avpkt->data;
> >>+    const uint8_t *buf = avpkt->data;
> >>+    int buf_size = avpkt->size;
> >
> >Once more with feeling: Align columns where appropriate.  Do you intend
> >to continue to ignore this comment?
> 
> Not sure what you mean. Something like this?
> 
> > +    const uint8_t *headerBuffer = avpkt->data;
> > +    const uint8_t *buf          = avpkt->data;
> > +    int buf_size                = avpkt->size;

Yes.

If you don't understand a review comment, ask for clarification,
don't just ignore it.

Diego