[FFmpeg-devel] [PATCH] Add DPX decoder rev-5

[Diego Biurrun]

On Mon, May 11, 2009 at 07:28:55AM +0200, Jimmy Christensen wrote:
> On 2009-05-11 07:11, Jimmy Christensen wrote:
> >
> >Everything else should be fixed now.
> 
> Whoops. Forgot Changelog and documentation.
> 
> --- Changelog	(revision 18736)
> +++ Changelog	(working copy)
> @@ -15,6 +15,7 @@
>  - introduced avlanguage helpers in libavformat
> +- added DPX image decoder

s/added//

> --- libavcodec/dpx.c	(revision 0)
> +++ libavcodec/dpx.c	(revision 0)
> @@ -0,0 +1,181 @@
> +
> +    /* Check if the files "magic number" is "SDPX" which means it uses
> +     * big endian or XPDS which is for little endian files */

big-endian, little-endian

> +    // Jump in extra 744 bytes to end in address 744 + 4 + 4 + 8 = 760 = 0x2f8

Jump an extra ... to end at ...

> +    av_log(NULL, AV_LOG_ERROR, "test\n");

debug cruft?

> +    ptr = p->data[0];
> +    stride = p->linesize[0];
> +
> +    *picture = s->picture;
> +    *data_size = sizeof(AVPicture);

align

> --- doc/general.texi	(revision 18736)
> +++ doc/general.texi	(working copy)
> @@ -240,6 +240,8 @@
>      @tab Only uncompressed GIFs are generated.
>  @item BMP          @tab X @tab X
>      @tab Microsoft BMP image
> + at item DPX          @tab X @tab X
> +    @tab Digital Picture Exchange

I did not see you add an encoder.

Diego