[FFmpeg-devel] [PATCH] Implement av_set_options_string()

[Michael Niedermayer]

On Thu, May 14, 2009 at 09:44:22PM +0200, Stefano Sabatini wrote:
> On date Wednesday 2009-05-13 23:44:22 +0200, Stefano Sabatini encoded:
> > On date Tuesday 2009-05-12 01:11:58 +0200, Michael Niedermayer encoded:
> > > On Mon, May 11, 2009 at 11:23:01PM +0200, Stefano Sabatini wrote:
> > [...]
> > > > +/**
> > > > + * Parses the key/value pairs list in opts. For each key/value pair
> > > > + * found, stores the value in the field in ctx that is named like the
> > > > + * key. ctx must be an AVClass context, storing is done using
> > > > + * AVOptions.
> > > > + *
> > > > + * @param key_val_sep a 0-terminated list of characters used to
> > > > + * separate key from value
> > > > + * @param pairs_sep a 0-terminated list of characters used to separate
> > > > + * two pairs from each other
> > > > + * @return the number of successfully set key/value pairs, a negative
> > > > + * value corresponding to an AVERROR* error code if opts cannot be
> > > > + * parsed, if no matching option exists for a key, or if a value is
> > > > + * not valid
> > > 
> > > please document which codes are used for which case
> > 
> > I'm documenting it indirectly with a reference to the av_set_string3()
> > error codes, hope it's OK like this.
> 
> Updated.

probably ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090515/c8306248/attachment.pgp>