[FFmpeg-devel] [PATCH] Move MLP's dot product to DSPContext

[Michael Niedermayer]

On Fri, May 15, 2009 at 10:38:01AM -0300, Ramiro Polla wrote:
> Hi,
> 
> On Fri, May 15, 2009 at 5:49 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Thu, May 14, 2009 at 07:44:36PM -0300, Ramiro Polla wrote:
> >>
> >> /*
> >> ?* Copyright (c) 2009 Ramiro Polla
> >
> > Extra good karma for adding a short explanatory line to the top of the
> > file.
> 
> Added.
> 
> >> #if ARCH_X86_64 || (ARCH_X86_32 && HAVE_7REGS)
> >>
> >>
> >> #if ARCH_X86_64
> >>
> >> #else /* ARCH_X86_32 && HAVE_7REGS */
> >>
> >> #endif
> >>
> >> #endif /* ARCH_X86_64 || (ARCH_X86_32 && HAVE_7REGS) */
> >
> > This had me confused for a moment, please comment the #endif.
> 
> I used Loren's suggestion and added some comments to the endifs.
> 
> I also fixed the indentation of the function declaration and
> simplified the constraints ifdef bit more. And also removed some
> unnecessarily exported symbols and renamed them.
[...]
>         : [s]"r"(state),
>           [c]"r"(coeff),
>           [b]"r"(sample_buffer),
>           [i]CONSTRAINT(blocksize),
>           [mask   ]CONSTRAINT((x86_reg)mask),
>           [firjump]CONSTRAINT(firjump),
>           [iirjump]CONSTRAINT(iirjump),
>           [shift  ]COUNTER(filter_shift),
>           [binc]"i"(sizeof(int32_t)* MAX_CHANNELS),
>           [is  ]"i"(sizeof(int32_t)*(MAX_FIR_ORDER + MAX_BLOCKSIZE)),
>           [ic  ]"i"(sizeof(int32_t)* MAX_FIR_ORDER)

this would break gcc 2.95 (fate)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090515/cd5e38dd/attachment.pgp>