[FFmpeg-devel] [PATCH] Clean up properly in ffplay

Michael Niedermayer michaelni
Fri May 15 18:12:39 CEST 2009


On Mon, May 11, 2009 at 11:09:59PM +0300, Martin Storsj? wrote:
> Hi,
> 
> The following two attached patches try to clean up properly in ffplay. The 
> first patch adds a few frees to do_exit, similar to ffmpeg.c, and frees 
> the VideoState structure in stream_close. The second patch moves 
> img_convert_ctx to the VideoState structure, so it can be properly cleaned 
> up on exit.

> 
> // Martin
>  ffplay.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> a242ea7719d0b95a3d29d5ec8f0933c15859b21a  0001-ffplay-cleanup.patch
[...]
>  ffplay.c |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> a3e92def1181b8a763327df15132d44d1e7462ed  0002-move-img_context_ctx-cleanup.patch
[...]


looks ok, though just to be sure please check with valgrind that
there are no double frees

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090515/f4980eed/attachment.pgp>



More information about the ffmpeg-devel mailing list