[FFmpeg-devel] [PATCH 4/5] Add PCE support to the ADTS muxer.

[Alex Converse]

On Tue, May 19, 2009 at 8:43 AM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>
> On Wed, May 13, 2009 at 03:42:06PM -0400, Alex Converse wrote:
> > On Wed, May 13, 2009 at 1:26 AM, Alex Converse <alex.converse at gmail.com> wrote:
> > > ---
> > > ?libavformat/adtsenc.c | ? 29 ++++++++++++++++++++++++-----
> > > ?1 files changed, 24 insertions(+), 5 deletions(-)
> > >
> > >
> >
> > New patch to compensate for changes in 0003
>
> > diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c
> > index 3d57724..7f2260b 100644
> > --- a/libavformat/adtsenc.c
> > +++ b/libavformat/adtsenc.c
> > @@ -23,6 +23,7 @@
> > ?#include "libavcodec/get_bits.h"
> > ?#include "libavcodec/put_bits.h"
> > ?#include "libavcodec/internal.h"
> > +#include "libavcodec/mpeg4audio.h"
> > ?#include "avformat.h"
> >
> > [...]
> >
> > + ? ? ? ?adts->pce_size = (ff_copy_pce_data(&pb, &gb) + 3) / 8;
>
> Looks like this file can be compiled without mpeg4audio.c being compiled.
> You probably need to add a Makefile dependency like this:

But none of the other (de)muxers that require mpeg4audio.c (flvdec.c,
matroska{enc,dec}.c, mov.c) use Makefile dependencies. Should they be
changed as well?

[...]

Regards,
Alex