[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 13)

[Cyril Russo]

Diego Biurrun a ?crit :
> On Wed, May 20, 2009 at 01:22:32PM +0200, Cyril Russo wrote:
>   
>> Diego Biurrun a ?crit :
>>     
>>> On Wed, May 20, 2009 at 10:06:32AM +0200, Cyril Russo wrote:
>>>  
>>>       
>>>> --- libavcodec/vaapi_h264.c	(r??vision 0)
>>>> +++ libavcodec/vaapi_h264.c	(r??vision 0)
>>>> @@ -0,0 +1,338 @@
>>>> +/** End an hardware decoding based frame. */
>>>>         
>>> a hardware
>>>  
>>>       
>> Done. An hour but a hardware.
>> Never got used to which h-prefixed words needs "an" or "a".
>>     
>
> Those where the 'h' is actually pronounced.  "hour" is pronounced like
> "our", while the 'h' at the beginning of "hardware" is audible.
>
>   
>> --- libavcodec/vaapi_h264.c	(r??vision 0)
>> +++ libavcodec/vaapi_h264.c	(r??vision 0)
>> @@ -0,0 +1,341 @@
>> +
>> +/** Initialize a empty VAAPI picture.
>>     
>
> an empty
>
>   
>> +/** Translate an FFmpeg Picture into its VAAPI form. 
>> + *  @param[out] va_pic          A pointer to VAAPI's own picture struct
>> + *  @param[in]  pic             A pointer to the FFmpeg picture struct to convert
>> + *  @param[in]  pic_structure   The picture field type to use, as defined in mpegvideo.h 
>> + *                              (can be 0 to use pic's reference) */
>>     
>
> How can a picture field type be a reference?
>
> Do you mean that if it is 0, this indicates that the field type of pic
> will be used?
>
>   

Exactly.
Changed to (can be 0 to use pic's field type).

>> +/** Append Picture into the decoded picture buffer, in a VAAPI form that 
>> + *  merges the second field picture attributes with the first, if any.
>>     
>
> if available
>
>   
>> + *  The decodec picture buffer's size must be large enough 
>>     
>
> decodeD
>
>   
>> +/** Initialize VAAPI reference picture lists from the FFmpeg reference picture list.
>> + *  @param[out] RefPicList  The VAAPI's internal reference picture list
>>     
>
> VAAPI
>
>   
>> + *  @param[in]  ref_list    A pointer to FFmpeg's own reference list
>>     
>
> A pointer to the FFmpeg reference list
>
>   
>> +/** Initialize prediction weight table.
>> + *  VAAPI requires plain prediction weight table as it doesn't infer 
>>     
>
> requires a, does not
>
>   
>> + *  @param[in]  h                   A pointer to the current H264 context
>>     
>
> H.264
>   

Missed that one

>   
>> + *  @param[in]  list                The index of the reference frame list to use
>> + *  @param[out] luma_weight_flag    The VAAPI's plain luma weight flag 
>> + *  @param[out] luma_weight         The VAAPI's plain luma weight table 
>> + *  @param[out] luma_offset         The VAAPI's plain luma offset table  
>> + *  @param[out] chroma_weight_flag  The VAAPI's plain chroma weight flag  
>> + *  @param[out] chroma_weight       The VAAPI's plain chroma weight table
>> + *  @param[out] chroma_offset       The VAAPI's plain chroma offset table */
>>     
>
> Drop all articles and 's.
>
> I can't say what the exact rule is but you don't use the definite
> article together with names in this way.  You say
>
> Diego's unprofessional grammar advice.
>
> instead of
>
> The Diego's unprofessional grammar advice.
>   

You're disgressing your own rule here (still have a 's in the 
examples).  ;-)
Anyway, I've got the point.


> Diego
>
> P.S.: Please leave empty lines between your text and quotes, this would
> make your mails much more readable, thanks.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
>
>   

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg.hwaccel.vaapi.h264.13.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090520/19db8490/attachment.txt>