[FFmpeg-devel] [RFC] Fixing libx264.c

[Jason Garrett-Glaser]

On Thu, May 21, 2009 at 8:54 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, May 21, 2009 at 08:02:32PM -0700, Jason Garrett-Glaser wrote:
>> > AVCodecContext.scenechange_threshold == 0 means default, not disabled
>> > disabled would be INT_MAX
>> > Its a simple bug in libx264.c of not translating from lavc API to x264 API
>>
>> So if(!scenecut threshold) {leave it as x264's default} ?
>
> yes, though the else case possibly shouldnt be = either, i would need to check
> x264s source to see what it does (maybe tomorrow, i need some sleep ATM)

The current behavior is:

0 --> No scenecut detection
1-100 -> Varying threshold
40 -> Default threshold

> i dont really mind these be set as you see fit currently
> though they should not be inconsistent with other things like CODEC_FLAG_4MV

What do you mean by inconsistent here?  P8x8 already has a separate
option from 4mv, even though it means a relatively similar thing.

Dark Shikari