[FFmpeg-devel] [PATCH] add libopencore support for AMR variants

[Ramiro Polla]

Hello Diego,

On Fri, May 22, 2009 at 8:19 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Fri, May 22, 2009 at 07:17:30PM -0300, Ramiro Polla wrote:
>> On Fri, May 22, 2009 at 7:15 AM, Diego Biurrun <diego at biurrun.de> wrote:
>> > The LGPL v3 configure changes would be committed separately.
>>
>> > @@ -2386,6 +2402,9 @@
>> > ?license="LGPL version 2.1 or later"
>> > ?if enabled nonfree; then
>> > ? ? ?license="nonfree and unredistributable"
>> > +elif enabled lgplv3; then
>> > + ? ?license="LGPL version 3 or later"
>> > + ? ?enabled gpl && license="GPL version 3 or later"
>> > ?elif enabled gpl; then
>> > ? ? ?license="GPL version 2 or later"
>> > ?fi
>>
>> lgpl v3 + gpl = gpl v3 ?
>
> Yes of course, what else?

lgplv3 implying that gpl will be v3 is not entirely obvious.

And your patch also misses changes to cmdutils.c

Ramiro Polla