[FFmpeg-devel] [PATCH] add libopencore support for AMR variants

[Diego Biurrun]

On Sat, May 23, 2009 at 12:05:10AM -0300, Ramiro Polla wrote:
> On Fri, May 22, 2009 at 11:42 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, May 22, 2009 at 08:55:32PM -0300, Ramiro Polla wrote:
> >> On Fri, May 22, 2009 at 8:19 PM, Diego Biurrun <diego at biurrun.de> wrote:
> >> > On Fri, May 22, 2009 at 07:17:30PM -0300, Ramiro Polla wrote:
> >> >> On Fri, May 22, 2009 at 7:15 AM, Diego Biurrun <diego at biurrun.de> wrote:
> >> >> > The LGPL v3 configure changes would be committed separately.
> >> >>
> >> >> > @@ -2386,6 +2402,9 @@
> >> >> > ?license="LGPL version 2.1 or later"
> >> >> > ?if enabled nonfree; then
> >> >> > ? ? ?license="nonfree and unredistributable"
> >> >> > +elif enabled lgplv3; then
> >> >> > + ? ?license="LGPL version 3 or later"
> >> >> > + ? ?enabled gpl && license="GPL version 3 or later"
> >> >> > ?elif enabled gpl; then
> >> >> > ? ? ?license="GPL version 2 or later"
> >> >> > ?fi
> >> >>
> >> >> lgpl v3 + gpl = gpl v3 ?
> >> >
> >> > Yes of course, what else?
> >>
> >> lgplv3 implying that gpl will be v3 is not entirely obvious.
> >
> > What makes you think otherwise?
> 
> This might lead to misinterpretations like "but I only wanted lgpl to
> be v3. I wanted the rest to be whatever is the default. that's what I
> asked for in configure". And before you suggest that only retarted
> people would think that, look again at the license violations on
> roundup...

You are right that we should try to make this as foolproof as possible.
How about $attached?

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: version3.diff
Type: text/x-diff
Size: 3632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090524/9b62fcc3/attachment.diff>