[FFmpeg-devel] cavs.c DECLARE_ALIGNED in ff_cavs_filter

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> Hello,
> currently there is this code in cavs.c:
>     DECLARE_ALIGNED_8(uint8_t, bs[8]);
> The reason for it is that kind of code:
>> *((uint64_t *)bs) = 0x0202020202020202ULL;
>> if( *((uint64_t *)bs) ) {
>
> I thought of "solving" this via a union, but is this code really this
> speed critical that we need such a mess?
> Can't we just use memset for the writes and e.g. AV_RN64 for the read?

Such huge literals are fairly inefficient anyway on most CPUs.

-- 
M?ns Rullg?rd
mans at mansr.com