[FFmpeg-devel] [PATCH] Fix compilation when MMX is disabled

[Graham Booker]

On May 25, 2009, at 12:16 PM, Diego Biurrun wrote:

> On Mon, May 25, 2009 at 05:03:35PM +0000, Jai Menon wrote:
>> On Mon, May 25, 2009 at 5:01 PM, Diego Biurrun <diego at biurrun.de>  
>> wrote:
>>> On Mon, May 25, 2009 at 04:26:06PM +0000, Jai Menon wrote:
>>>> On Mon, May 25, 2009 at 4:00 PM, Reimar D?ffinger
>>>> <Reimar.Doeffinger at gmx.de> wrote:
>>>>> On Mon, May 25, 2009 at 03:12:50PM +0000, Jai Menon wrote:
>>>>>> As in subject.
>>>>>
>>>>> Looks completely wrong, mlpdsp asm does not use MMX.
>>>>
>>>> I know it doesn't use MMX, but couldn't find any other way to do  
>>>> it. I
>>>> was hoping somebody would suggest the correct way. Should there  
>>>> be a
>>>> X86-OBJS ?
>>>
>>> OBJS-$(ARCH_X86), similar to what we have for all other ARCHs.
>>
>> And how should the CONFIG_MLP_DECODER and CONFIG_TRUEHD_DECODER flags
>> be checked?
>
> With the same trick that we use for e.g. MMX-OBJS and OBJS-$ 
> (HAVE_MMX).
>

I ran into this too.  There doesn't seem to be an X86-OBJS variable,  
so I created one.  This seems to work for me:

Index: libavcodec/Makefile
===================================================================
--- libavcodec/Makefile	(revision 18944)
+++ libavcodec/Makefile	(working copy)
@@ -441,14 +441,16 @@
  YASM-OBJS-$(CONFIG_GPL)                += x86/ 
h264_deblock_sse2.o       \
                                            x86/ 
h264_idct_sse2.o          \

+X86-OBJS-$(CONFIG_MLP_DECODER)         += x86/mlpdsp.o
+X86-OBJS-$(CONFIG_TRUEHD_DECODER)      += x86/mlpdsp.o
+OBJS-$(ARCH_X86)                       += $(X86-OBJS-yes)
+
  MMX-OBJS-$(CONFIG_CAVS_DECODER)        += x86/cavsdsp_mmx.o
  MMX-OBJS-$(CONFIG_ENCODERS)            += x86/dsputilenc_mmx.o
  MMX-OBJS-$(CONFIG_FLAC_ENCODER)        += x86/flacdsp_mmx.o
  MMX-OBJS-$(CONFIG_GPL)                 += x86/idct_mmx.o
-MMX-OBJS-$(CONFIG_MLP_DECODER)         += x86/mlpdsp.o
  MMX-OBJS-$(CONFIG_SNOW_DECODER)        += x86/snowdsp_mmx.o
  MMX-OBJS-$(CONFIG_THEORA_DECODER)      += x86/vp3dsp_mmx.o x86/ 
vp3dsp_sse2.o
-MMX-OBJS-$(CONFIG_TRUEHD_DECODER)      += x86/mlpdsp.o
  MMX-OBJS-$(CONFIG_VC1_DECODER)         += x86/vc1dsp_mmx.o
  MMX-OBJS-$(CONFIG_VP3_DECODER)         += x86/vp3dsp_mmx.o x86/ 
vp3dsp_sse2.o
  MMX-OBJS-$(CONFIG_VP5_DECODER)         += x86/vp3dsp_mmx.o x86/ 
vp3dsp_sse2.o


> Diego


- Graham


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090525/27c8f2f2/attachment.bin>