[FFmpeg-devel] [PATCH] forgotten "enable ppc64" for arch == ppc64

Diego Biurrun diego
Mon May 25 23:53:35 CEST 2009


On Mon, May 25, 2009 at 09:40:58PM +0200, Reimar D?ffinger wrote:
> On Mon, May 25, 2009 at 08:10:05PM +0100, M?ns Rullg?rd wrote:
> > Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > 
> > > I noticed that on the FATE ppc64 machine HAVE_PPC64 is 0.
> > > This I think should fix it, though I am not sure how it is _supposed_
> > > to behave:
> > > --- configure   (revision 18938)
> > > +++ configure   (working copy)
> > > @@ -1516,6 +1516,7 @@
> > >          arch="ppc"
> > >          enable fast_64bit
> > >          enable fast_unaligned
> > > +        enable ppc64
> > >      ;;
> > >
> > > It seems quite messed-up still, because the CPU check does enable ppc64
> > > for G5|g5|970|ppc970|PowerPC970|power4*|Power4*|Cell|CELL|cell
> > > but doesn't seem to set "enable fast_64bit" for those??
> > 
> > HAVE_PPC64 should be changed to ARCH_PPC64, and the subarch variable
> > in configure set accordingly.  This and fast_64bit should be set in
> > $arch handling, not $cpu.
> 
> not possible, $arch is handled before $cpu and $cpu enables ppc64.
> Still I think attached patch might work (test is still running).

Well, we already do it for SPARC and MIPS, it should be OK..

Diego



More information about the ffmpeg-devel mailing list