[FFmpeg-devel] [RFC][PATCH] return packets for known codecs earlier when codec probing is done

[Michael Niedermayer]

On Mon, May 25, 2009 at 01:10:12PM -0700, Baptiste Coudurier wrote:
[...]
> Index: libavformat/avformat.h
> ===================================================================
> --- libavformat/avformat.h	(revision 18912)
> +++ libavformat/avformat.h	(working copy)
> @@ -443,6 +443,12 @@
>       * AV_NOPTS_VALUE by default.
>       */
>      int64_t reference_dts;
> +
> +    /**
> +     * number of packets buffered for codec probing
> +     */
> +#define MAX_PROBE_PACKETS 100
> +    unsigned probe_packets;

i think initializing it to 100 and countig to 0 is more flexible
also it should be marked in the doxy as not being part of the public
API for now

besides this and the improvment you found, the patch does look ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090526/1f1f5db2/attachment.pgp>