[FFmpeg-devel] [PATCH] image2 bugfix for image2pipe

[Peter Holik]

> On 2009-05-26 16:45, Peter Holik wrote:
>>> On Tue, May 26, 2009 at 03:04:05PM +0200, Peter Holik wrote:
>>>
>>>>> cosmetics must be seperate from functional changes, its not
>>>>> possible to review patches with reasonable effort otherwise
>>>>>
>>>> 02-image2-cosmetics-for-image2pipe.patch contains some cosmetics on
>>>>   img_read_packet -> "if(!s->is_pipe)" check is not needed anymore.
>>>>
>>> Still contains cosmetics.
>>>
>>
>> right, but now the patches should be correct seperated in functional changes (01)
>> and cosmetics ones (02)
>>
>> cu Peter
>
>
>> @@ -306,6 +298,37 @@
>>      }
>>  }
>>
>> +static int img_read_packet_pipe(AVFormatContext *s1, AVPacket *pkt)
>> +{
>>
>> [...]
>>
>> +    return 0;
>> +}
>> +
>
>
> shouldn't that be under #if CONFIG_IMAGE2PIPE_DEMUXER ?
>
>> +    if (url_feof(s1->pb))
>> +            return AVERROR(EIO);
>>
>
> weird indentation

corrected

cu Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-image2-bugfix-for-image2pipe.patch
Type: text/x-diff
Size: 2422 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090526/bb373ac5/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-image2-cosmetics-for-image2pipe.patch
Type: text/x-diff
Size: 1761 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090526/bb373ac5/attachment-0001.patch>