[FFmpeg-devel] [PATCH] Fix 64 bit truncation in asfdec.c

[Michael Niedermayer]

On Wed, May 27, 2009 at 11:07:34PM -0700, David DeHaven wrote:
>
> Looking at some ms-dvr files I noticed the WM/EncodingTime tags (among 
> others) were reporting goofy numbers. Turns out get_value was returning int 
> but parsing 64 bit values. This patch corrects that.
>
> -DrD-
>

>  asfdec.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> c42aa6d7e4fe6d834db4bbb0e639a93cf293e4d6  fix-asfdec-truncation.diff
> Index: libavformat/asfdec.c
> ===================================================================
> --- libavformat/asfdec.c	(revision 18971)
> +++ libavformat/asfdec.c	(working copy)
> @@ -140,13 +140,13 @@
>          return 0;
>  }
>  
> -static int get_value(ByteIOContext *pb, int type){
> +static uint64_t get_value(ByteIOContext *pb, int type){

why do you change it from signed to unsigned?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090528/3036640c/attachment.pgp>