[FFmpeg-devel] [BUG] h264 picture reordering fails

[Haruhiko Yamagata]

I found picture reordering fails in
http://x264.nl/h.264.samples/premiere-paff.ts

Outputted pictures have POC {-4, -2, 4, 0, 2, 6}.
Are negative POCs allowed?

If yes, zero as POC is valid as well.

But, in h264.c decode_frame,
            for(i=1; h->delayed_pic[i] && (h->delayed_pic[i]->poc && !h->delayed_pic[i]->key_frame); i++)
This code assume poc zero is special. The case above is not supported.
If I comment out /* h->delayed_pic[i]->poc && */, then it works for the sample.

This is just a bug report, but if you give me a hint, I'm willing to work on this.

The method to reproduce,
1. As soon as playback starts, press pause.
2. Seek to around 00:09. POC is negative.
3. At 00:11, a midfielder kicks a ball. Look at the ball or POC frame-by-frame.

Best regards,
Haruhiko Yamagata