[FFmpeg-devel] [PATCH] Move ff_reverse in libavcodec to av_reverse in libavutil

[Francesco Lavra]

On Sat, 2009-11-07 at 23:49 +0100, Michael Niedermayer wrote:
> On Sat, Nov 07, 2009 at 09:44:21PM +0100, Reimar D?ffinger wrote:
> > On Sat, Nov 07, 2009 at 09:21:56PM +0100, Michael Niedermayer wrote:
> > > On Sat, Nov 07, 2009 at 08:48:49PM +0100, Reimar D?ffinger wrote:
> > > > Sorry if this is a bit confusing, this is basically carried over
> > > > from a MPlayer discussion I think.
> > > > The main question I'd say is whether ff_reverse should be moved to
> > > > libavutil and independently from that whether it should be made part
> > > > of the public API as av_reverse.
> > > 
> > > what advantage is there in moving it into libavutil?
> > 
> > That MPlayer makes no effort to compiler without libavutil while
> > it was once supposed to work without libavcodec.
> > Not that I consider that really relevant, I suggested libavutil
> > without really thinking about it.
> 
> Well, i dont mind moving it into lavutil if you think thats a good
> idea
> 
> 
> > 
> > > about making it public, if some projects wants to use it iam fine with
> > > that of course.
> > 
> > So renaming ff_reverse to av_reverse and put extern declaration in
> > avcodec.h? Or some other header?
> 
> yes

The attached patch renames ff_reverse to av_reverse, and moves its
definition from libavcodec/utils.c to libavutil/mathematics.c and its
extern declaration from libavcodec/get_bits.h to libavutil/common.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ff_reverse.patch
Type: text/x-patch
Size: 9450 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091108/a15f734c/attachment.bin>