[FFmpeg-devel] [PATCH] reuse extern_prefix for YASMFLAGS -DPREFIX

Reimar Döffinger Reimar.Doeffinger
Sun Nov 8 23:41:20 CET 2009


On Sun, Nov 08, 2009 at 10:28:45PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > Hello,
> > instead of the ugly hardcode, this sets yasm -DPREFIX when we detected something
> > for extern_prefix.
> > Actually this only works if extern_prefix is either not set at all or _,
> > anything else is currently not supported by the YASM code (though it would
> > be easy to extend).
> > Index: configure
> > ===================================================================
> > --- configure	(revision 20477)
> > +++ configure	(working copy)
> > @@ -2232,10 +2232,10 @@
> >      YASMFLAGS="-f $objformat -DARCH_$(toupper $subarch)"
> >      enabled     x86_64        && append YASMFLAGS "-m amd64"
> >      enabled     pic           && append YASMFLAGS "-DPIC"
> > +    test -n "$extern_prefix"  && append YASMFLAGS "-DPREFIX"
> >      case "$objformat" in
> >          elf) enabled debug && append YASMFLAGS "-g dwarf2" ;;
> > -        macho64)              append YASMFLAGS "-DPIC -DPREFIX" ;;
> > -        *)                    append YASMFLAGS "-DPREFIX"  ;;
> > +        macho64)              append YASMFLAGS "-DPIC" ;;
> >      esac
> >      disabled yasm || { check_yasm "pabsw xmm0, xmm0" && enable yasm; }
> 
> Looks reasonable.  Commit if tested.

Tested on Linux and OSX, I'd think that should cover everything.
So applied.



More information about the ffmpeg-devel mailing list