[FFmpeg-devel] [FFMPEG] [PATCH] cavs encoder

[zhihang wang]

Thank you for your comments. I have some questions on the comments as
following.

On Tue, Nov 17, 2009 at 2:24 AM, Diego Biurrun <diego at biurrun.de> wrote:

>
> > +
> > +static int (*me)(AVSContext *h, enum cavs_block blk_sz, int blk_idx,
> > +                 int ref, cavs_vector* pmv, cavs_vector* mv);
> > +static int (*bi_me)(AVSContext *h, enum cavs_block blk_sz, int blk_idx,
> > +                 int ref, cavs_vector* pmv, cavs_vector* mv);
>
> Again, please avoid forward declarations.
>
*Sorry. because these are two function pointers, I don't know how to use
them without forward declarations Would you like to give me some ideas?*

>
> > +        if ((level > CAVS_MAX_LEVEL)||(run > CAVS_MAX_RUN)
> > +                ||((level_code = enc->rlcode[run][level]) < 0)) {
>
> alignment
>

*Sorry. I don't know the alignment rule.  Is the following is ok?*
> +        if ((level > CAVS_MAX_LEVEL)||(run > CAVS_MAX_RUN)
> +             ||((level_code = enc->rlcode[run][level]) < 0))  {



> > +static void partition_copy_c(uint8_t *src, int src_stride, uint8_t *dst,
> int dst_stride, int w, int h)
>
> Please break lines over 80 characters where easily possible.
> *
> *

*Do I need to break ALL lines over 80 characters?*

>
> --
Best Regards
zhihang wang(???)