[FFmpeg-devel] [PATCH] Fix possible SIGFPEs with bad mov timings. Based on chromium patch 35_mov_bad_timings.patch

[Baptiste Coudurier]

On 11/19/2009 10:52 AM, Michael Niedermayer wrote:
> On Thu, Nov 19, 2009 at 12:12:30PM -0500, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Thu, Nov 19, 2009 at 1:45 AM, Baptiste Coudurier
>> <baptiste.coudurier at gmail.com>  wrote:
>>> I don't like the<  0 check, but I guess we don't have much choice here.
>>
>> Er...
>>
>> A) AVURational (bikeshed!!!!111)
>
> no i wont buy you a second bike because you dont like the color of the one
> you alraedy have
>
>
>> B) uint32_t num = READ_BE32(..), den = READ_BE32(..);
>>      if (num&  0x80000000 || den&  0x80000000) { den>>= 1; num>>= 1 }
>
> dont do this period
> we have av_reduce() that does this properly, and av_set_pts_info() already
> uses it.

num is 1 for mov.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org