[FFmpeg-devel] [PATCH] encoder for adobe's flash ScreenVideo2 codec

[Michael Niedermayer]

On Fri, Nov 20, 2009 at 04:14:28PM +0100, Benjamin Larsson wrote:
[...]
>> diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
>> index 27062dc..2be5e2d 100644
>> --- a/libavformat/flvdec.c
>> +++ b/libavformat/flvdec.c
>> @@ -82,6 +82,7 @@ static int flv_set_video_codec(AVFormatContext *s, 
>> AVStream *vstream, int flv_co
>>      switch(flv_codecid) {
>>          case FLV_CODECID_H263  : vcodec->codec_id = CODEC_ID_FLV1   ; 
>> break;
>>          case FLV_CODECID_SCREEN: vcodec->codec_id = CODEC_ID_FLASHSV; 
>> break;
>> +        case FLV_CODECID_SCREEN2: vcodec->codec_id = CODEC_ID_FLASHSV2; 
>> break;
>>          case FLV_CODECID_VP6   : vcodec->codec_id = CODEC_ID_VP6F   ;
>>          case FLV_CODECID_VP6A  :
>>              if(flv_codecid == FLV_CODECID_VP6A)
>>   
>
> This hunk looks ok, but I'm not the maintainer.

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091120/857c1876/attachment.pgp>