[FFmpeg-devel] [PATCH] set mp3 time base to sample rate

[Baptiste Coudurier]

On 11/22/09 8:29 AM, Michael Niedermayer wrote:
> On Sat, Nov 21, 2009 at 08:39:12PM -0800, Baptiste Coudurier wrote:
>> Hi,
>>
>> $subject, this gives a more correct frame duration than 90000.
>>
>> --
>> Baptiste COUDURIER
>> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
>> FFmpeg maintainer                                  http://www.ffmpeg.org
>
>>   mp3.c |    4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>> c769680f950c344ab9336ee148333ad04db73d8a  mp3_sample_rate.patch
>
> This is ok in principle but there are mp3 streams with some initial
> broken frames that cant be detected excpet by checking future frames
> (see libavcodec/mpegaudio_parser.c for example of what that needs)
> these could lead to the wrong samplerate being detected
>
> maybe simply using 1/14112000 would work?

Good idea, I did that and added a comment clarifying the value.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org