[FFmpeg-devel] [PATCH] RF64 demuxer

Michael Niedermayer michaelni
Fri Oct 2 21:03:56 CEST 2009


On Fri, Oct 02, 2009 at 01:37:27PM -0500, Daniel Verkamp wrote:
> On Fri, Oct 2, 2009 at 5:09 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Oct 01, 2009 at 06:07:45PM -0500, Daniel Verkamp wrote:
> [...]
> >> +/** Get RF64-style 64-bit integer */
> >> +static int64_t get_rf64(ByteIOContext *pb)
> >> +{
> >> + ? ?int64_t val;
> >> + ? ?val ?= get_le32(pb);
> >> + ? ?val |= (int64_t)get_le32(pb) << 32;
> >> + ? ?return val;
> >> +}
> >
> > get_le64() ?
> 
> Yes, somehow I had decided that the order was backwards from normal
> LE64, but it's the same; removed.
> 
> >
> >> +
> >> +static int rf64_read_header(AVFormatContext *s, AVFormatParameters *ap)
> >
> > this looks similar enough to the normal one to be merged with it
> 
> True; new patch attached.
> 
> Thanks,
> -- Daniel Verkamp

> From 9eec0ed61a4e720b2aa4f4edc2f4625ed144aeec Mon Sep 17 00:00:00 2001
> From: Daniel Verkamp <daniel at drv.nu>
> Date: Fri, 2 Oct 2009 14:35:04 -0400
> Subject: [PATCH] RF64 support in WAV demuxer

patch looks ok (assuming its tested and all that of course)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091002/21c3ea18/attachment.pgp>



More information about the ffmpeg-devel mailing list