[FFmpeg-devel] [PATCH] Add debug facilities for avfilter.c

[Michael Niedermayer]

On Mon, Oct 05, 2009 at 10:37:10PM +0200, Michael Niedermayer wrote:
> On Mon, Oct 05, 2009 at 09:34:50PM +0200, Stefano Sabatini wrote:
> > On date Monday 2009-10-05 00:32:40 +0200, Michael Niedermayer encoded:
> > > On Sun, Oct 04, 2009 at 06:40:12PM +0200, Stefano Sabatini wrote:
[...]
> > > the buffers and snprintf() are useless, a single av_log call is enough
> > 
> > How? I'd like to keep the dprint_STUFF functions, so it's easy to
> > add/customize other traces in other places if necessary.
> 
> you have a single function that prints it all and you call that single
> function from various places
> that function is #defined to ; if DEBUG is not set
> you pass NULL if you dont have some link or picref
> the fuction just calls av_log() or dprintf()
> 
> this is simpler than your code

it also could be 2 functions, one for picref and one for link
but the snprintf + buffers + av_log is unneeded they can print directly


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091005/ac37863b/attachment.pgp>