[FFmpeg-devel] [PATCH]Allow decoding of eac3 in mpegts

[Baptiste Coudurier]

On 10/10/09 2:19 PM, Carl Eugen Hoyos wrote:
> Baptiste Coudurier<baptiste.coudurier<at>  gmail.com>  writes:
>
>>> +    { 0x84, CODEC_TYPE_AUDIO, CODEC_ID_EAC3 },
>>>        { 0x90, CODEC_TYPE_SUBTITLE, CODEC_ID_HDMV_PGS_SUBTITLE },
>>>        { 0 },
>>>    };
>>>
>>
>> I have no objection to the patch.
>
> Applied.
>
>> We might also want to probe it sucessfully.
>>
>> Can you please test that set_codec_from_probe_data returns eac3 raw
>> demuxer ? It could then be enabled.
>
> Sorry, I don't understand: The eac3 raw muxer and demuxer work fine with this
> sample (but that was probably not what you meant).
>

Technically, the codec id is set to CODEC_ID_PROBE, to enable codec 
autodetection due to the many private streams in ts. The codec probing 
system should probe correctly EAC3 ideally, however it seems that the 
raw eac3 demuxer is not checked against in set_codec_from_probe_data, I 
was wondering if adding it would make the codec sucessfully probed.

I hope it more clear :)

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org