[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

[Diego Biurrun]

On Tue, Oct 13, 2009 at 01:05:04PM +0200, Reimar D?ffinger wrote:
> --- tools/costablegen.c	(revision 0)
> +++ tools/costablegen.c	(revision 0)
> @@ -0,0 +1,25 @@
> +#include <stdio.h>
> +#include "libavcodec/dsputil.h"

Please add license headers even for simple files.

> --- libavcodec/dsputil.h	(revision 20222)
> +++ libavcodec/dsputil.h	(working copy)
> @@ -742,7 +742,11 @@
>  
> -extern FFTSample* const ff_cos_tabs[13];
> +extern
> +#if CONFIG_HARDCODED_TABLES
> +const
> +#endif
> +FFTSample* const ff_cos_tabs[13];
> -extern FFTSample* const ff_cos_tabs[13];

I think the following is more readable:

  #if CONFIG_HARDCODED_TABLES
  extern const FFTSample* const ff_cos_tabs[13];
  #else
  extern FFTSample* const ff_cos_tabs[13];
  #endif

Diego