[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Oct 14, 2009 at 01:39:46PM +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Wed, Oct 14, 2009 at 01:35:10PM +0200, Reimar D?ffinger wrote:
>> >> 
>> >> --- libavcodec/Makefile	(revision 20231)
>> >> +++ libavcodec/Makefile	(working copy)
>> >> @@ -28,6 +28,7 @@
>> >>  OBJS-$(CONFIG_AANDCT)                  += aandcttab.o
>> >>  OBJS-$(CONFIG_ENCODERS)                += faandct.o jfdctfst.o jfdctint.o
>> >>  OBJS-$(CONFIG_FFT)                     += fft.o
>> >> +HARDCODED-TABLES-OBJS-$(CONFIG_FFT)    += cos_tables.o
>> >
>> > FFT-OBJS-$(CONFIG_HARDCODED_TABLES)    += cos_tables.o
>> > OBJS-$(CONFIG_FFT)                     += fft.o $(FFT-OBJS-yes)
>> >
>> > That should make some of your other changes unnecessary.
>> >
>> >> --- libavcodec/cos_tables.h	(revision 0)
>> >> +++ libavcodec/cos_tables.h	(revision 0)
>> >> @@ -0,0 +1,17 @@
>> >> +#ifndef AVCODEC_COS_TABLES_H
>> >> +#define AVCODEC_COS_TABLES_H
>> >
>> > Please the standard license header (and maybe a few empty lines).
>> 
>> It's a list of numbers, hardly subject to copyright.  You're being a
>> bit too pedantic.
>
> Sure.  But there is not a person on this project that would remember to
> add the license boilerplate when the header stops being just a list of
> numbers.  OK, so this particular header might stay a bunch of numbers
> for life, but what about the next file where the boilerplate gets
> skipped?  You will quickly find yourself in gray areas.  It's much
> simpler to add the boilerplate everywhere and never have to worry.

It's a generated file for crying out loud.  Give it a rest.

-- 
M?ns Rullg?rd
mans at mansr.com